Skip to content

Commit

Permalink
libxl: disable VNC and SDL until explicitly enabled
Browse files Browse the repository at this point in the history
When initializing a libxl_domain_build_info struct with
libxl_domain_build_info_init(), VNC is enabled by default.  As a
result, VMs configured with no graphics still have VNC enabled.
This behavior is a regression wrt to the legacy Xen driver.

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  • Loading branch information
marmarek authored and jfehlig committed Feb 12, 2015
1 parent 8703ee5 commit 98780c6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/libxl/libxl_conf.c
Expand Up @@ -745,6 +745,10 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
return -1;
}

/* Disable VNC and SDL until explicitly enabled */
libxl_defbool_set(&b_info->u.hvm.vnc.enable, 0);
libxl_defbool_set(&b_info->u.hvm.sdl.enable, 0);

/*
* The following comment and calculation were taken directly from
* libxenlight's internal function libxl_get_required_shadow_memory():
Expand Down

0 comments on commit 98780c6

Please sign in to comment.