Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test under MODEL_FACTORY_INJECTIONS #72

Merged
merged 2 commits into from Jun 15, 2015
Merged

Test under MODEL_FACTORY_INJECTIONS #72

merged 2 commits into from Jun 15, 2015

Conversation

gnarf
Copy link
Contributor

@gnarf gnarf commented May 2, 2015

I found a strange bug with the primaryKey when MODEL_FACTORY_INJECTIONS was on.

Fixing.

@dgeb
Copy link
Member

dgeb commented Jun 15, 2015

@gnarf what's the status on this?

@gnarf
Copy link
Contributor Author

gnarf commented Jun 15, 2015

I'll rebase it to make sure it still up to date, but it was passing last I checked

@dgeb
Copy link
Member

dgeb commented Jun 15, 2015

thanks 👍

dgeb added a commit that referenced this pull request Jun 15, 2015
@dgeb
Merge pull request #72 from gnarf/model-factory-injections
3f1d756 
Test under MODEL_FACTORY_INJECTIONS
@dgeb dgeb merged commit 3f1d756 into orbitjs:master Jun 15, 2015
@gnarf gnarf deleted the model-factory-injections branch June 15, 2015 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnarf @dgeb