RemoveRecord when part of has many relationship should not clobber the whole relationship in IndexedDB source #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchak
force-pushed
the
remove-record-clobber-persisted-source
branch
from
624eb72
to
311c6a7
Compare
tchak
changed the title
tchak
changed the title
tchak
force-pushed
the
remove-record-clobber-persisted-source
branch
from
311c6a7
to
a484268
Compare
…e whole relationship
tchak
force-pushed
the
remove-record-clobber-persisted-source
branch
from
a484268
to
b190e34
Compare
|
@tchak fantastic - thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexedDBsource clobber parent record relationship when one of the members of the given relationship is removed. I added arecord-cacheandlocal-storagetests to show that the problem is scoped toIndexedDBsource.