Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements in typings #789

Merged
merged 3 commits into from Sep 28, 2020
Merged

Further improvements in typings #789

merged 3 commits into from Sep 28, 2020

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Sep 27, 2020

Continues the linting / typing work done in #788:

  • Introduces a new compile task to ensure that all test and src dirs compile without any issues
  • Streamlines and standardizes eslint settings

@dgeb dgeb marked this pull request as ready for review September 28, 2020 16:37
@dgeb
Introduce compile task that runs tsc for everything
7d0c9a2 
Only `src` is compiled in the `build` task. By compiling `test` as well, we can let `tsc` catch any errors in tests.
@dgeb
Streamline eslint settings
c871b92
@dgeb
Fix typing and linting issues
1b7d16d
@dgeb dgeb merged commit e510859 into master Sep 28, 2020
@dgeb dgeb deleted the strict-2 branch September 28, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dgeb