Improve perf by cloning only newly added relationship #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively safes a lot of time when dealing with a large number of operations
dgeb
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally loading a large amount of records (e.g. 5000) with a relationship was very slow. The reason seems to be that with each
updateRecordoperation, thefinallyaction for thesync-cache-integrity-processorprocessor took more and more time - in the end up to 3ms per relationship per operation. This is because it was deep cloning the list of inverse relationships each time, which grew with each time.As discussed with @dgeb , changed to clone only the newly added relationship.