Ensure that schema + source upgrades are reliably async #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgeb
force-pushed
the
schema-upgrades
branch
2 times, most recently
from
9d63184
to
2bb78a6
Compare
`fulfillAll` will emit events and fulfill responses simultaneously via `Promise.all`. This is similar to (but different from) `fulfillInSeries`, which fulfills responses in order, one after the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ensure that a call to
await schema.upgrade(settings)will complete by the time all listeners (i.e. typically sources that share this schema) have completed their upgrades (which may occur async).Listeners are invoked with a new
fulfillAllmethod forEventedobjects, which usesPromise.allto fulfill any promises that may be returned by listeners.A cleanup pass was also made on sources to ensure that they all provide an async
upgrademethod.