Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF] Unify modifiers #26

Closed
3 tasks done
odyslam opened this issue Feb 13, 2023 · 1 comment · Fixed by #47
Closed
3 tasks done

[INF] Unify modifiers #26

odyslam opened this issue Feb 13, 2023 · 1 comment · Fixed by #47

Comments

@odyslam
Copy link
Contributor

odyslam commented Feb 13, 2023

Description

The codebase makes extensive use of modifiers. There is room for consolidation and simplification to improve the readability of the codebase.

Suggestion

@lekevicius
Copy link
Collaborator

Can we separate this issue? I fully agree with removing modifiers from getters and UX guardrails, but less convinced on removing onlyHolderHeld. Maybe that can be moved to a separate issue, and then we can confirm this smaller one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants