Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove onlyHolderHeld if onlyHolder AND external are in the same function: setPrice, exit, flagResponse. If it's external, it can't be called by the contract itself. #30

Closed
Tracked by #26
odyslam opened this issue Feb 16, 2023 · 1 comment · Fixed by #48
Closed
Tracked by #26

Remove onlyHolderHeld if onlyHolder AND external are in the same function: setPrice, exit, flagResponse. If it's external, it can't be called by the contract itself. #30

odyslam opened this issue Feb 16, 2023 · 1 comment · Fixed by #48
Labels
confirmed Let's do this

Comments

@odyslam
Copy link
Contributor

odyslam commented Feb 16, 2023 •
edited

Description

#26

Suggestion

Removee onlyHolderHeld if onlyHolder and external are present in the function.

Affected functions: setPrice, exit, flagResponse.
This was referenced Feb 16, 2023
Closed
Merged
@lekevicius
Copy link
Collaborator

Great suggestion.

@lekevicius lekevicius added the confirmed Let's do this label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed Let's do this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Audit: Address #30 odyslam/orb
2 participants
@lekevicius @odyslam