Launch Management Chain for E2E #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, no Docker, no remote
# Conflicts: # test/e2e/multi_chain_test.go
…rbs-network/orbs-network-go into feature/simple-multi-chain-e2e
…rbs-network/orbs-network-go into feature/simple-multi-chain-e2e
|
race detector falls (https://circleci.com/gh/orbs-network/orbs-network-go/18624?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) on LH race condition, Issue fixed in orbs-network/lean-helix-go#70 |
|
@itamararjuan need your help with ci/e2e - |
electricmonk
approved these changes
Sep 10, 2019
| @@ -127,7 +127,7 @@ jobs: | |||
|
|
|||
| deploy_testnet: | |||
| docker: | |||
| - image: circleci/node:11.2.0 | |||
| - image: itamararjuan/golang_with_node_aws | |||
There was a problem hiding this comment.
@itamararjuan why are you using your own image?
config/system_factory_presets.go
Outdated
| constantConsensusLeader primitives.NodeAddress, | ||
| activeConsensusAlgo consensus.ConsensusAlgoType, | ||
| ) NodeConfig { | ||
| func ForE2E(httpAddress string, virtualChainId primitives.VirtualChainId, gossipListenPort int, nodeAddress primitives.NodeAddress, nodePrivateKey primitives.EcdsaSecp256K1PrivateKey, gossipPeers map[string]GossipPeer, genesisValidatorNodes map[string]ValidatorNode, blockStorageDataDirPrefix string, processorArtifactPath string, ethereumEndpoint string, constantConsensusLeader primitives.NodeAddress, activeConsensusAlgo consensus.ConsensusAlgoType) NodeConfig { |
| @@ -51,7 +51,7 @@ services: | |||
| ipv4_address: 192.168.199.12 | |||
|
|
|||
|
|
|||
| orbs-network-node-1: | |||
| orbs-app-chain-node-1: | |||
There was a problem hiding this comment.
this file has become long and repetitive; please see if we can simplify it (separate PR)
test/e2e/harness.go
Outdated
| "", | ||
| primitives.NodeAddress{}, | ||
| 0). | ||
| return config.ForE2E("", 0, 0, primitives.NodeAddress{}, primitives.EcdsaSecp256K1PrivateKey{}, nil, nil, "", "", "", primitives.NodeAddress{}, 0). |
|
@ronnno merge on Sunday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launch a second virtual chain for e2e tests:
100000 + (prNumber * 2)for mgmt chain and100000 + (prNumber * 2 + 1)for app chainfor in-process e2e harness:
8090, 8090+1,...,8090+(n-1)8090+n, 8090+(n+1),...,8090(2n-1)test/e2e/_tmp/contract compiler work dir) and virtual chain data dir will be appended by a vchain id component of the form:vcid_[vcid]