Support for 1.18 generics #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very cool. I am looking forward to reviewing this soon |
|
@ImVexed You missed the .travis.yml file. |
Not particularly sure what's failing now or why. |
|
@ImVexed Even though you're using a beta version, seems to be the same issue as with the 1.18rc1... Seems that golangci-lint have some issues with it... google/go-github#2296 |
|
any updates? Looking forward to generics support |
|
@chbomtempo seems to be working fine now that 1.18 is out |
|
Thanks @ImVexed , you rock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found myself beginning to port some personal projects to 1.18 and found that this library didn't yet have any support for generics. So, I figured I might as well take a swing at it.
I'm not exactly sure what the right path is for making this available is since 1.18 is still a beta. Regardless, hopefully this is useful to others :)