Setting for login/logout redirect view #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 23, 2012 15:12
|
|
||
| The template used to prompt the user to integrate their Fitbit. | ||
| The URL to which to redirect the user after successful Fitbit integration, if | ||
| no 'next' URL is known. |
There was a problem hiding this comment.
"to which to redirect the user" seems kind of awkward, to me anyway. We could say "which the user is redirected to"?
Could we say something about how Fitapp would know a 'next' URL?
|
|
ghost
pushed a commit
that referenced
this pull request
Oct 24, 2012
Setting for login/logout redirect view
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'fitbit' named URL and associated view and template have been removed in favor of redirecting to:
GET['next']/session['fitbit_next']URL, if it is available, orFITAPP_LOGIN_REDIRECTor`FITAPP_LOGOUT_REDIRECT`` defined in settings.The
fitbit_requireddecorator has been renamed tofitbit_integration_warning. It has also been refactored to accept a message argument, which defaults toFITAPP_DECORATOR_MESSAGEdefined in settings.Also included additional tests & a .coveragerc file.