ignore badrequest errors for floors/elevation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brad Looks like a good solution to me. |
|
LGTM too. |
percyperez
added a commit
that referenced
this pull request
Nov 17, 2015
ignore badrequest errors for floors/elevation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grokcode @percyperez Please review.
According to a Fitbit employee it is expected that the API will return an HTTP 400 error for "floors" and "elevation" data when the user does not have a device with an altimeter. My simple workaround is to ignore these types of errors for these resource types. In real world testing, we see that we get the errors for the
floors,tracker/floors,elevation, andtracker/elevationresource types.