Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#111022166] enable fitbit subscriber verification #28

Merged
merged 2 commits into from
Jan 5, 2016

Conversation

brad
Copy link
Member

@brad brad commented Jan 5, 2016

@orcasgit/orcas-developers Please review. This adds support for verifying subscriber endpoints. I made some maintenance updates too:

  • Use six to simplify string type checking in Python 2/3
  • Use simplejson to simplify json error handling across Python 2/3
  • Create HTML coverage report when running tests
  • Ignore migration directories in coverage reports
  • Handle specific exceptions in update view
  • Update upper end of requirements to the latest tested versions
  • Drop support for Python 3.2, which is no longer supported in the latest version of coverage

The verification code fitbit assigns to your app for the purpose of `verifying
subscriber endpoints
<https://dev.fitbit.com/docs/subscriptions/#verify-a-subscriber>`_. This is
optional, and is only needed if you plan on subscriber to user data updates. To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brad Nitpick: should be "subscribing to user data updates"

@grokcode
Copy link
Contributor

grokcode commented Jan 5, 2016

@brad Other than that typo in the docs, looks great!

grokcode added a commit that referenced this pull request Jan 5, 2016
[#111022166] enable fitbit subscriber verification
@grokcode grokcode merged commit 1b87fae into master Jan 5, 2016
@grokcode grokcode deleted the subscriber-verification branch January 5, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants