Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku status checks not updating when PR opened from forked repo #559

Open
paulcretu opened this issue Jul 31, 2024 · 1 comment
Open

Comments

@paulcretu
Copy link
Member

paulcretu commented Jul 31, 2024

The main branch in this repo has required status checks enabled to make sure that the Heroku deployment succeeds before allowing the PR to be merged. This works fine for PRs that are opened from a feature branch in this repo. However, when a PR is opened from a fork, the deployment_status workflow trigger errors out (here's an example).

As a result the status checks annoyingly get stuck as "waiting for status"
image

The workflow trigger error seems to be a bug with Github, for which I opened a ticket (please vote up if you can!)

Workarounds:

  1. A while back, I tried to add a command to trigger a manual refresh (Add command to manually refresh Heroku status in PRs #503), but it doesn't work—the issue_comment workflow trigger doesn't have the necessary metadata to create an API request. With some more effort, it could probably be made to work, but it's not very high priority at this time
  2. Find another way to update Heroku status (that doesn't rely on the deployment_status trigger)
  3. Disable the status checks
  4. Manually bypass status checks
  5. Avoid making PRs from forks
@paulcretu
Copy link
Member Author

paulcretu commented Jul 31, 2024

Given that this is pretty low priority, I plan on just relying on 4 & 5 until Github responds/fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: triage
Development

No branches or pull requests

1 participant