Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove builder cache pvc #1225

Merged
merged 7 commits into from
Sep 1, 2022
Merged

Remove builder cache pvc #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eaeb371
Deprecate builder-cache-pvc
fruttasecca Aug 24, 2022
2de11d3
Delete BuilderCachePVC during manageOrchestCluster
fruttasecca Aug 24, 2022
6ccc86e
Update orchest-cli/orchestcli/cli.py
fruttasecca Aug 24, 2022
96b0fad
Move echo and jecho to utils
fruttasecca Aug 24, 2022
e4f9769
Move builder_pvc deprecation check to cli module
fruttasecca Aug 24, 2022
12863c2
Bump cli semver
fruttasecca Aug 24, 2022
373765c
Update orchest-cli/orchestcli/_version.py
fruttasecca Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/source/development/appendix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Overview of the different paths inside the `/userdir`.
│ ├── database
│ │ └── data
│ │ └── <postgres data store>
│ ├── buildkit-cache
│ ├── jupyter-img-builds
│ ├── env-img-builds
│ ├── orchest_examples_data.json
Expand Down
2 changes: 1 addition & 1 deletion orchest-cli/orchestcli/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.5.1"
__version__ = "0.6.0"
12 changes: 8 additions & 4 deletions orchest-cli/orchestcli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
from gettext import gettext

import click
from orchestcli import cmds
from orchestcli import cmds, utils
from orchestcli._version import __version__

NAMESPACE = "orchest"
Expand Down Expand Up @@ -205,9 +205,9 @@ def cli():
"--builder-pvc-size",
"builder_pvc_size",
type=click.IntRange(min=5),
default=50,
default=None,
show_default=True,
help="Size of the image builder volume claim in Gi.",
help="(DEPRECATED) Size of the image builder volume claim in Gi.",
)
@click.option(
"--registry-pvc-size",
Expand All @@ -231,6 +231,11 @@ def install(
**common_options,
) -> None:
"""Install Orchest."""

if builder_pvc_size is not None:
# REMOVABLE_ON_BREAKING_CHANGE
utils.echo("The 'builder_pvc_size' parameter is deprecated and ignored.")

cmds.install(
multi_node,
cloud,
Expand All @@ -239,7 +244,6 @@ def install(
fqdn,
socket_path,
userdir_pvc_size,
builder_pvc_size,
registry_pvc_size,
**common_options,
)
Expand Down