Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Orchest PVCs with no ownerReferences #1254

Merged
merged 1 commit into from Sep 13, 2022
Merged

Adopt Orchest PVCs with no ownerReferences #1254

merged 1 commit into from Sep 13, 2022

Conversation

nhaghighat
Copy link
Contributor

@nhaghighat nhaghighat commented Sep 13, 2022 •
edited

Description

This PR adopts the PVCs if the owner of PVC is nil, technically this should never happen. Still, it has been added because of the way https://velero.io/ creates a backup, the PVCs that Valero backups don't maintain the original ownerRefrences.

Checklist

  • I have manually tested my changes and I am happy with the result.
  • The documentation reflects the changes.
  • The PR branch is set up to merge into dev instead of master.

@yannickperrenet yannickperrenet added the improvement An improvement or enhancement to an existing feature. label Sep 13, 2022
@yannickperrenet
Copy link
Contributor

@alexsanderp 👼

@nhaghighat nhaghighat merged commit 9ee8f4e into dev Sep 13, 2022
@nhaghighat nhaghighat deleted the feat/own-pvcs-if-they-dont-have-owner branch September 13, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannickperrenet yannickperrenet yannickperrenet approved these changes

Assignees
No one assigned
Labels
improvement An improvement or enhancement to an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhaghighat @yannickperrenet