Add jupyter builds and interactive sessions events to orchest-api (notifications)
#950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruttasecca
added
improvement
fruttasecca
changed the title
orchest-api
fruttasecca
changed the title
orchest-apiorchest-api (notifications)
This allows to keep track of what subset of the pipeline nodes where used for the interactive run.
The constraint already exists under the form of a FK to pipelines, given our db schema and the fact that we are using single table inheritance this constraint is not compatible in some edge cases and redundant in others.
Given that pretty much all session related calls needs a project and pipeline UUID it clearly shows that sessions are a events._register_interactive_session_service_restarted(
project_uuid, pipeline_uuid
) |
Alright sounds good 👍 |
…ts-to-orchest-api Add project and pipeline events to `orchest-api` (notifications)
…-api Add environment created/delete events to `orchest-api` (notifications)
…orchest-api Move job_update event to the `orchest-api` (notifications)
…thub.com:orchest/orchest into improv/add-interactive-runs-event-to-orchest-api
…t-to-orchest-api Add interactive pipeline run events to `orchest-api` (notifications)
…active-session:pipeline-run:*
…hest into improv/add-builds-events-to-orchest-api
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for jupyter builds and interactive sessions events to the
orchest-api, these events can now be subscribed to and are now part of the analytics module.@yannickperrenet one point of discussion for me here would be about the conceptual nesting of events, i.e.
project:interactive-session:startedvs a possibleproject:pipeline:interactive-session:started. I have currently gone for the former but I have no strong feelings about it (not even mild tbh), would be good to reach a consensus pre-merge to avoid breaking schemas later.Checklist
models.pyI have performed the appropriate databasemigrations (refer to
scripts/migration_manager.sh).