Skip to content

Commit

Permalink
Merge 178f45b into a534d69
Browse files Browse the repository at this point in the history
  • Loading branch information
crynobone committed Sep 28, 2023
2 parents a534d69 + 178f45b commit f4ac397
Show file tree
Hide file tree
Showing 61 changed files with 416 additions and 2,402 deletions.
1 change: 1 addition & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
os:
- "ubuntu-latest"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Which will output the following as `canvas.yaml`:
preset: package

namespace: PackageName
user-auth-provider: App\User
user-auth-model: App\User

paths:
src: src
Expand Down
14 changes: 3 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,12 @@
"php": "^8.1",
"composer-runtime-api": "^2.2",
"composer/semver": "^3.0",
"illuminate/console": "^10.25.1",
"illuminate/database": "^10.25.1",
"illuminate/support": "^10.25.1",
"orchestra/canvas-core": "^8.8",
"orchestra/testbench-core": "^8.11",
"laravel/framework": "dev-generator-presets as 10.x-dev",
"orchestra/canvas-core": "dev-generator-presets as 8.x-dev",
"orchestra/testbench-core": "^8.10.2",
"symfony/yaml": "^6.2"
},
"require-dev": {
"laravel/framework": "^10.25.1",
"laravel/pint": "^1.6",
"mockery/mockery": "^1.5.1",
"phpstan/phpstan": "^1.10.5",
Expand All @@ -56,11 +53,6 @@
"extra": {
"branch-alias": {
"dev-master": "9.0-dev"
},
"laravel": {
"providers": [
"Orchestra\\Canvas\\LaravelServiceProvider"
]
}
},
"scripts": {
Expand Down
15 changes: 0 additions & 15 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,3 @@ parameters:
message: "#^Unable to resolve the template type TMakeValue in call to method static method Illuminate\\\\Support\\\\Collection\\<\\(int\\|string\\),mixed\\>\\:\\:make\\(\\)$#"
count: 1
path: src/Console/Commander.php

-
message: "#^Parameter \\#1 \\$model of method Illuminate\\\\Routing\\\\Console\\\\ControllerMakeCommand\\:\\:parseModel\\(\\) expects string, array\\|bool\\|string\\|null given\\.$#"
count: 2
path: src/Console/ControllerMakeCommand.php

-
message: "#^Parameter \\#2 \\$callback of function transform expects callable\\(array\\|bool\\|string\\|null\\)\\: string, Closure\\(string\\)\\: string given\\.$#"
count: 1
path: src/Console/PresetMakeCommand.php

-
message: "#^Parameter \\#2 \\$callback of function transform expects callable\\(array\\|bool\\|string\\|null\\)\\: string, Closure\\(string\\)\\: string given\\.$#"
count: 2
path: src/Console/ViewMakeCommand.php
24 changes: 13 additions & 11 deletions src/CanvasServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

namespace Orchestra\Canvas;

use Illuminate\Console\Generators\PresetManager;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Contracts\Support\DeferrableProvider;
use Illuminate\Support\Arr;
use Illuminate\Support\ServiceProvider;
use Orchestra\Canvas\Core\PresetManager;
use Symfony\Component\Yaml\Yaml;

class CanvasServiceProvider extends ServiceProvider implements DeferrableProvider
Expand All @@ -18,13 +18,15 @@ class CanvasServiceProvider extends ServiceProvider implements DeferrableProvide
*/
public function register(): void
{
$this->callAfterResolving(PresetManager::class, function ($manager, $app) {
$manager->extend('canvas', function ($app) {
return new GeneratorPreset($app);
});
if (class_exists(PresetManager::class)) {
$this->callAfterResolving(PresetManager::class, function ($manager, $app) {
$manager->extend('canvas', function ($app) {
return new GeneratorPreset($app);
});

$manager->setDefaultDriver('canvas');
});
$manager->setDefaultDriver('canvas');
});
}

$this->app->singleton('orchestra.canvas', function (Application $app) {
$workingPath = \defined('CANVAS_WORKING_PATH') ? CANVAS_WORKING_PATH : $this->app->basePath();
Expand Down Expand Up @@ -56,8 +58,10 @@ public function boot(): void
if ($this->app->runningInConsole()) {
$this->commands([
Console\CodeMakeCommand::class,
Console\FactoryMakeCommand::class,
Console\GeneratorMakeCommand::class,
Console\PresetMakeCommand::class,
Console\TestMakeCommand::class,
Console\ViewMakeCommand::class,
]);
}
}
Expand All @@ -69,8 +73,6 @@ public function boot(): void
*/
public function provides()
{
return [
'orchestra.canvas',
];
return ['orchestra.canvas'];
}
}
7 changes: 7 additions & 0 deletions src/Console/BatchesTableCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ class BatchesTableCommand extends \Illuminate\Queue\Console\BatchesTableCommand
{
use MigrationGenerator;

/**
* The type of class being generated.
*
* @var string
*/
protected $type = 'Migration';

/**
* Create a new notifications table command instance.
*
Expand Down
63 changes: 0 additions & 63 deletions src/Console/CastMakeCommand.php

This file was deleted.

65 changes: 0 additions & 65 deletions src/Console/ChannelMakeCommand.php

This file was deleted.

4 changes: 2 additions & 2 deletions src/Console/CodeMakeCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Orchestra\Canvas\Console;

use Orchestra\Canvas\Core\Commands\GeneratorCommand;
use Orchestra\Canvas\Core\Concerns\ResolvesPresetStubs;
use Illuminate\Console\GeneratorCommand;
use Illuminate\Console\Generators\Concerns\ResolvesPresetStubs;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Input\InputOption;

Expand Down
12 changes: 6 additions & 6 deletions src/Console/Commander.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

namespace Orchestra\Canvas\Console;

use Illuminate\Console\GeneratorCommand;
use Illuminate\Contracts\Console\Kernel as ConsoleKernel;
use Illuminate\Foundation\Application as LaravelApplication;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Illuminate\Support\Collection;
use Illuminate\Console\GeneratorCommand;
use Orchestra\Canvas\CanvasServiceProvider;
use Orchestra\Canvas\LaravelServiceProvider;
use Illuminate\Contracts\Console\Kernel as ConsoleKernel;
use Illuminate\Foundation\Application as LaravelApplication;
use Symfony\Component\Console\Command\Command as SymfonyCommand;

class Commander extends \Orchestra\Testbench\Console\Commander
Expand Down Expand Up @@ -42,10 +42,10 @@ public function laravel()
if (! $this->app instanceof LaravelApplication) {
$app = parent::laravel();

$kernel = $app->make(ConsoleKernel::class);

$app->register(LaravelServiceProvider::class);

$kernel = $app->make(ConsoleKernel::class);

Collection::make($kernel->all())
->reject(function (SymfonyCommand $command, string $name) {
return Str::startsWith('make:', $name) || $command instanceof GeneratorCommand;
Expand Down
88 changes: 0 additions & 88 deletions src/Console/ComponentMakeCommand.php

This file was deleted.

0 comments on commit f4ac397

Please sign in to comment.