[RFC] Fix ControlMenuHandler authorize method

[quetzyg]

Hi,

I did a fresh Orchestra Platform install and after the initial setup I started activating extensions.
As soon as I activated the Control Extension, I got a InvalidArgumentException in the AuthorizationTrait.php with the following message:

Unable to verify unknown action manage roles. (line 61).

I had a look at other *MenuHandler classes and in all of them, the authorize() method is checking the ACL with the canIf() method, while in this particular case the can() is being used.
Using canIf() fixed my issue, but I don't know if using can() was actually intended.

Let me know what you think.

Cheers,
Quetzy

[crynobone]

Thanks 👍

[quetzyg]

Btw, can you backport this fix to the 3.1 branch?

[quetzyg]

Oh, I see you already tagged 3.1.6, it's just packagist that hasn't updated yet. I'll wait.

[crynobone]

Yeah, I'm out for dinner. Will be available in an hour.