Restructure to use static function.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
orchestral · Aug 4, 2019 · dfe5827 · dfe5827
1 parent 867d120
commit dfe5827
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/FacileServiceProvider.php b/src/FacileServiceProvider.php
@@ -15,14 +15,13 @@ class FacileServiceProvider extends ServiceProvider implements DeferrableProvide
      */
     public function register()
     {
-        $this->app->singleton('orchestra.facile', function (Application $app) {
-            $factory = new Factory($app, $app->make('request'));
-            $template = new Template\Simple($app->make('view'), new Transformable());
+        $this->app->singleton('orchestra.facile', static function (Application $app) {
+            return \tap(new Factory($app, $app->make('request')), function ($factory) use ($app) {
+                $template = new Template\Simple($app->make('view'), new Transformable());
 
-            $factory->name('default', $template);
-            $factory->name('simple', $template);
-
-            return $factory;
+                $factory->name('default', $template);
+                $factory->name('simple', $template);
+            });
         });
     }
 

diff --git a/src/Template/Composers/Csv.php b/src/Template/Composers/Csv.php
@@ -48,7 +48,7 @@ public function streamCsv(array $data = [], $status = 200, array $config = []):
 
         $collection = $this->convertToCsvable($data, $config);
 
-        return Response::stream(function () use ($collection) {
+        return Response::stream(static function () use ($collection) {
             $collection->streamCsv();
         }, $status, [
             'Content-Type' => 'text/csv',