Use pull instead get and forget.

Signed-off-by: crynobone <crynobone@gmail.com>
orchestral · Nov 14, 2014 · 825ed2f · 825ed2f
1 parent e1dd05a
commit 825ed2f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/Messages/MessageBag.php b/src/Messages/MessageBag.php
@@ -73,11 +73,9 @@ public function retrieve()
             $this->instance->setSessionStore($this->session);
 
             if ($this->session->has('message')) {
-                $messages = @unserialize($this->session->get('message', ''));
+                $messages = unserialize($this->session->pull('message'));
             }
 
-            $this->session->forget('message');
-
             if (is_array($messages)) {
                 $this->instance->merge($messages);
             }

diff --git a/tests/MessageBagTest.php b/tests/MessageBagTest.php
@@ -85,9 +85,8 @@ public function testRetrieveMethod()
     {
         $session = m::mock('\Illuminate\Session\Store');
         $session->shouldReceive('has')->once()->andReturn(true)
-            ->shouldReceive('get')->once()
-                ->andReturn('a:2:{s:5:"hello";a:1:{i:0;s:8:"Hi World";}s:3:"bye";a:1:{i:0;s:7:"Goodbye";}}')
-            ->shouldReceive('forget')->once()->andReturn(true);
+            ->shouldReceive('pull')->once()
+                ->andReturn('a:2:{s:5:"hello";a:1:{i:0;s:8:"Hi World";}s:3:"bye";a:1:{i:0;s:7:"Goodbye";}}');
 
         $retrieve = (new MessageBag)->setSessionStore($session)->retrieve();
         $retrieve->setFormat();
@@ -107,9 +106,8 @@ public function testExtendMethod()
     {
         $session = m::mock('\Illuminate\Session\Store');
         $session->shouldReceive('has')->once()->andReturn(true)
-            ->shouldReceive('get')->once()
-                ->andReturn('a:1:{s:5:"hello";a:1:{i:0;s:8:"Hi World";}}')
-            ->shouldReceive('forget')->once()->andReturn(true);
+            ->shouldReceive('pull')->once()
+                ->andReturn('a:1:{s:5:"hello";a:1:{i:0;s:8:"Hi World";}}');
 
         $callback = function ($msg) {
             $msg->add('hello', 'Hi Orchestra Platform');