[9.x] Reset refresh database state between tests

[crynobone]

No description provided.

[coveralls]

coverage: 92.414% (+0.01%) from 92.402%
when pulling 3a575f7 on 9/reset-refresh-database-state-between-tests
into c86b66e on 9.x.

[brunogaspar]

@crynobone Hello 👋

Sadly, this has caused a regression, at least on my end. I'm also aware this logic was moved to the InteractsWithTestCase trait.

I've been using the RefreshDatabase trait for quite some time, even after Laravel 11 upgrade, but after this change, the trait still works, but the migrations are executed before each test, which seems unwanted (at least from my point of view), which in turn makes the tests slow as the more migrations you have, the slow it will be 😞

Do i need to change something on my end?

Thank you!!

[crynobone]

See 8930529

[crynobone]

Oh yeah, my mistake. There are two RefreshDatabase usages in Testbench.

1. Consistent migrations per test case.
2. Ad-hoc migrations between tests in test cases.

While Laravel application mostly uses structure 1, Package developers have been known to use structure 2, which led to the above changes. We will need to rethink this

[brunogaspar]

No problem.

I'm pretty much on structure 1 but on a package, testing against a MySQL database not a in memory one (i know it's a bit unconventional).

I have for now implemented a workaround so it does not use the RefreshDatabaseState::$migrated

Let me know if there's anything i can help to address it.

[crynobone]

I'm pretty much on structure 1 but on a package, testing against a MySQL database not a in memory one (i know it's a bit unconventional).

RefreshDatabase in Laravel 11 for :in-memory: was changed to work similarly to a persistent database which prompted these changes (tests will break with structure 2).

[crynobone]

@brunogaspar can you test the latest patch release and see if that fixed your issue.

[brunogaspar]

@crynobone Yes, that seemed to have fixed it.

Thank you!!