Skip to content

Commit

Permalink
Merge branch '3.4'
Browse files Browse the repository at this point in the history
  • Loading branch information
crynobone committed Feb 24, 2017
2 parents 7ba1129 + 63b861a commit 2def2a0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,13 @@ This error would only occur if your test suite require actual usage of the encry
</phpunit>
```

### Why Testbench doesn't include any of the `App` classes.

The reason Testbench remove all the case is to make sure that you would never depends on it when developing Laravel Packages. Classes such as `App\Http\Controllers\Controller` and `App\User` may seem simple to be added but the problems with these classes is that it can be either:

* Removed, moved to other location such as `App\Models\User`, or
* Renamed using `php artisan app:name Acme` which would rename `App\User` to `Acme\User`.

### Missing Browser Kit support after testing on Laravel 5.4

Replace `orchestra/testbench` with `orchestra/testbench-browser-kit` and follow [the installation guide](https://github.com/orchestral/testbench-browser-kit#installation).
2 changes: 1 addition & 1 deletion src/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ protected function afterApplicationCreated(callable $callback)
*/
protected function beforeApplicationDestroyed(callable $callback)
{
$this->beforeApplicationDestroyedCallbacks[] = $callback;
array_unshift($this->beforeApplicationDestroyedCallbacks, $callback);
}

/**
Expand Down

0 comments on commit 2def2a0

Please sign in to comment.