Indent with spaces to follow PSR-2 and update 4.1 config #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: composer.json docs/readme.md src/fixture/app/config/database.php src/fixture/app/config/queue.php src/fixture/app/config/session.php src/fixture/app/config/view.php
|
Thank but this is not necessary, my focus with PSR-2 is to ensure that the code (mostly classes) are following a single coding standard for future benefit (easier for pull request to be made since the standard is clear). This shouldn't affect how other file behave because it doesn't need to. As of configuration, lets just stick with what Laravel is using, since we are only copying it from Laravel all the times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.