Skip to content

Commit

Permalink
Merge branch '2.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
crynobone committed Jun 15, 2013
2 parents 0d1677c + 8fb92f2 commit 27d725d
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 14 deletions.
4 changes: 3 additions & 1 deletion src/Orchestra/View/Decorator.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ class Decorator {
/**
* Registers a custom macro.
*
* @access public
* @param string $name
* @param Closure $macro
* @param \Closure $macro
* @return void
*/
public function macro($name, $macro)
Expand All @@ -30,6 +31,7 @@ public function macro($name, $macro)
* @param string $name
* @param array $data
* @return mixed
* @throws \BadMethodCallException
*/
public function render($name, $data = null)
{
Expand Down
7 changes: 5 additions & 2 deletions src/Orchestra/View/FileViewFinder.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ class FileViewFinder extends \Illuminate\View\FileViewFinder {
/**
* Get the fully qualified location of the view.
*
* @param string $name
* @access public
* @param string $name
* @return string
*/
public function find($name)
Expand All @@ -28,7 +29,8 @@ public function find($name)
/**
* Get the path to a template with a named path.
*
* @param string $name
* @access protected
* @param string $name
* @return string
*/
protected function findNamedPathView($name)
Expand All @@ -47,6 +49,7 @@ protected function findNamedPathView($name)
/**
* Set the active view paths.
*
* @access public
* @return array
*/
public function setPaths($paths)
Expand Down
15 changes: 7 additions & 8 deletions src/Orchestra/View/Theme/Container.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class Container {
/**
* Application instance.
*
* @var Illuminate\Foundation\Application
* @var \Illuminate\Foundation\Application
*/
protected $app = null;

Expand All @@ -31,26 +31,25 @@ class Container {
protected $path = null;

/**
* URL path of Theme
* URL path of theme.
*
* @var string
*/
protected $absoluteUrl = null;

/**
* Relative URL path of Theme
* Relative URL path of theme.
*
* @var string
*/
protected $relativeUrl = null;

/**
* Start Theme Engine, this should be called from Orchestra\Core::start()
* Start theme engine, this should be called from application booted
* or whenever we need to overwrite current active theme per request.
*
* @static
* @access public
* @param Illuminate\Foundation\Application $app
* @param \Illuminate\Foundation\Application $app
* @param string $name
* @return void
*/
Expand Down Expand Up @@ -115,7 +114,7 @@ public function boot()
// There might be situation where Orchestra Platform was unable
// to get theme information, we should only assume there a valid
// theme when manifest is actually an instance of
// Orchestra\View\Theme\Manifest
// Orchestra\View\Theme\Manifest.
if ( ! $manifest instanceof Manifest) return null;

// Loop and include all file which was mark as autoloaded.
Expand Down Expand Up @@ -153,7 +152,7 @@ public function to($url = '')
}

/**
* Relative URL helper for Theme
* Relative URL helper for theme.
*
* @access public
* @param string $url
Expand Down
8 changes: 5 additions & 3 deletions src/Orchestra/View/Theme/Manifest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Manifest {
/**
* Application instance.
*
* @var Illuminate\Filesystem\Filesystem
* @var \Illuminate\Filesystem\Filesystem
*/
protected $files = null;

Expand All @@ -23,8 +23,10 @@ class Manifest {
* Load the theme.
*
* @access public
* @param string $path
* @param \Illuminate\Filesystem\Filesystem $files
* @param string $path
* @return void
* @throws \RuntimeException
*/
public function __construct(Filesystem $files, $path)
{
Expand All @@ -36,7 +38,7 @@ public function __construct(Filesystem $files, $path)

if (is_null($this->items))
{
// json_decode couldn't parse, throw an exception
// json_decode couldn't parse, throw an exception.
throw new RuntimeException(
"Theme [{$path}]: cannot decode theme.json file"
);
Expand Down
2 changes: 2 additions & 0 deletions src/Orchestra/View/Theme/ThemeManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class ThemeManager extends Manager {
/**
* Create an instance of the orchestra theme driver.
*
* @access protected
* @return \Orchestra\View\Theme\Container
*/
protected function createOrchestraDriver()
Expand All @@ -17,6 +18,7 @@ protected function createOrchestraDriver()
/**
* Get the default authentication driver name.
*
* @access protected
* @return string
*/
protected function getDefaultDriver()
Expand Down

0 comments on commit 27d725d

Please sign in to comment.