Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm link issue #80

Merged
merged 4 commits into from Apr 18, 2020
Merged

fix npm link issue #80

merged 4 commits into from Apr 18, 2020

Conversation

emmkong
Copy link
Contributor

@emmkong emmkong commented Apr 17, 2020

NPM link issues

If you need to do npm link in your local environment you might encounter the following issues:

Both react and styled-components cause duplicate instance issue after npm link, to fix that we need to ensure both app project and lib project are sharing the same instance of them. ( * must follow the order of following commands )

  • in orcs-design-system folder,

    • npm link {PATH_APP_REPO}/node_modules/react
    • npm link {PATH_APP_REPO}/node_modules/styled-components
    • npn link
  • in {PATH_APP_REPO}

    • npm i orcs-design-system
    • npm start

@mariasereno-png mariasereno-png merged commit b3fb1f0 into master Apr 18, 2020
@mariasereno-png mariasereno-png deleted the npm-link branch April 18, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants