Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgramChange midi1RawBytes() #211

Closed
2 tasks done
kls943 opened this issue May 7, 2024 · 1 comment
Closed
2 tasks done

ProgramChange midi1RawBytes() #211

kls943 opened this issue May 7, 2024 · 1 comment
Assignees
Labels
🐞 bug Something isn't working 🎹 i/o MIDIKit I/O
Milestone

Comments

@kls943
Copy link

kls943 commented May 7, 2024

Please Confirm

  • I have reviewed the MIDIKit Documentation which contains descriptive guides and extensive API reference
  • I have searched Issues and Discussions to see if the same question has already been asked

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

Line 152 in ProgramChange.swift (func midi1RawBytes() -> [UInt8]) codes the Bank Select LSB (CC 32) as 0x32. But CC 32 is decimal 32. Line 152 should read 0x20

Crash Logs, Screenshots or Other Attachments (if applicable)

No response

orchetect added a commit that referenced this issue May 7, 2024
@orchetect
Copy link
Owner

orchetect commented May 7, 2024

Nice catch. Not sure how that got through unit testing, but I've performed the fix and updated unit tests.

Will be in next release (0.9.6).

@orchetect orchetect self-assigned this May 7, 2024
@orchetect orchetect added 🐞 bug Something isn't working 🎹 i/o MIDIKit I/O labels May 7, 2024
@orchetect orchetect added this to the 0.9.6 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎹 i/o MIDIKit I/O
Projects
None yet
Development

No branches or pull requests

2 participants