Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: If 'select' key is indecies, lost 'selected' attribute. Added unit test #2769

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fixed: If 'select' key is indecies, lost 'selected' attribute. Added unit test #2769

merged 3 commits into from
Dec 18, 2023

Conversation

lihe6666
Copy link
Contributor

@lihe6666 lihe6666 commented Dec 16, 2023 •
edited by tabuna

Fixes #2767

@tabuna
Copy link
Member

tabuna commented Dec 18, 2023

Hi @lihe6666, can you add a simple test?

@lihe6666 lihe6666 changed the title Fixed: If 'select' value is number, lost 'selected' attribute Fixed: If 'select' key is indecies, lost 'selected' attribute. Added unit test Dec 18, 2023
@lihe6666
Copy link
Contributor Author

@tabuna OK, I have resubmitted the request and added unit tests.

@tabuna tabuna merged commit 78f56fd into orchidsoftware:master Dec 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I use the "Select" field without setting the attribute "selected"
2 participants
@lihe6666 @tabuna