fix(document): enforce drop order on DocumentInner

[ordian]

@Boddlnagg, can you check whether this patch fixes #20?

[codecov]

Codecov Report

Merging #21 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #21      +/-   ##
=========================================
- Coverage   91.25%   91.2%   -0.06%     
=========================================
  Files          22      22              
  Lines        1361    1364       +3     
=========================================
+ Hits         1242    1244       +2     
- Misses        119     120       +1

Impacted Files	Coverage Δ
src/document.rs	98.21% <100%> (+0.1%)	⬆️
src/lib.rs	0% <0%> (-100%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a908b65...9387fcd. Read the comment docs.

[Boddlnagg]

Yes, this does fix the issue, in that the tests don't crash anymore!

There is still one test that doesn't pass, however: test_raw_multiline_string:

---- test_raw_multiline_string stdout ----
        thread 'test_raw_multiline_string' panicked at 'assertion failed: `(left == right)`
  left: `Object({"firstnl": Object({"type": String("string"), "value": String("This string has a \' quote character.")}), "multiline": Object({"type": String("string"), "value": String("This string\nhas \' a quote character\nand more than\none newline\nin it.")}), "oneline": Object({"type": String("string"), "value": String("This string has a \' quote character.")})})`,
 right: `Object({"firstnl": Object({"type": String("string"), "value": String("This string has a \' quote character.")}), "multiline": Object({"type": String("string"), "value": String("This string\r\nhas \' a quote character\r\nand more than\r\none newline\r\nin it.")}), "oneline": Object({"type": String("string"), "value": String("This string has a \' quote character.")})})`', tests\test_valid.rs:54:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Seems like the tests aren't expecting Windows \r\n newlines ... but this should also have been caught by AppVeyor?!

[Boddlnagg]

Ah, the newline thing might be related to how git checks out the files.

Specifically, I have the git autocrlf setting enabled, and AppVeyor might not use that (which would surprise me, though), leading to different encoding of line endings on checkout.

[ordian]

Thanks for confirming!

bors r+

\r\n is separate issue - it's a bug in the tests. Thanks for the report!

[bors]

Build succeeded

• continuous-integration/appveyor/branch
• continuous-integration/travis-ci/push