-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(document): enforce drop order on DocumentInner #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
- Coverage 91.25% 91.2% -0.06%
=========================================
Files 22 22
Lines 1361 1364 +3
=========================================
+ Hits 1242 1244 +2
- Misses 119 120 +1
Continue to review full report at Codecov.
|
Yes, this does fix the issue, in that the tests don't crash anymore! There is still one test that doesn't pass, however:
Seems like the tests aren't expecting Windows |
Ah, the newline thing might be related to how Specifically, I have the |
Thanks for confirming! bors r+ \r\n is separate issue - it's a bug in the tests. Thanks for the report! |
21: fix(document): enforce drop order on DocumentInner r=ordian @Boddlnagg, can you check whether this patch fixes #20?
Fix typos in CONTRIBUTING.md
@Boddlnagg, can you check whether this patch fixes #20?