Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mdbook language switch feature #2385

Closed
raphjaph opened this issue Aug 29, 2023 · 5 comments
Closed

Implement mdbook language switch feature #2385

raphjaph opened this issue Aug 29, 2023 · 5 comments

Comments

@raphjaph
Copy link
Collaborator

Would be great to have different languages for the docs, which are made with mdBook. In order to do that we would probably have to use https://github.com/google/mdbook-i18n-helpers. Unfortunately I do not have time to do that at the moment but happy to review the PR when it's done.

@DrJingLee
Copy link
Contributor

This is a demo of the website.

https://ordinals.education/

@ordinaHO
Copy link
Contributor

just saw your demo its great ! so with that you mean the main hand book should have a new JavaScript Code with Language Switcher and ralph will be able to add the languages , Im still trying to figure out what different mdbook helper will make for my translation.

@raphjaph
Copy link
Collaborator Author

just implemented the language picker in @DrJingLee's PR. Have a look!

@mgeisler
Copy link

mgeisler commented Sep 1, 2023

Nice, thanks for setting this up! I'm adding a link back in google/mdbook-i18n-helpers#71. Feel free to raise issues in the repository if you run into problems.

@raphjaph
Copy link
Collaborator Author

raphjaph commented Sep 5, 2023

Closing since we have implemented it now

@raphjaph raphjaph closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants