Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create wallet with a taproot descriptor #1158

Merged
merged 22 commits into from
Jan 9, 2023
Merged

create wallet with a taproot descriptor #1158

merged 22 commits into from
Jan 9, 2023

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Jan 3, 2023

No description provided.

casey
casey requested changes Jan 4, 2023
View reviewed changes
src/options.rs Outdated Show resolved Hide resolved
@raphjaph raphjaph marked this pull request as ready for review January 5, 2023 18:26
@raphjaph raphjaph requested a review from casey January 5, 2023 18:26
casey
casey requested changes Jan 5, 2023
View reviewed changes
src/options.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
tests/wallet/create.rs Outdated Show resolved Hide resolved
tests/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Show resolved Hide resolved
@raphjaph raphjaph requested a review from casey January 6, 2023 00:35
casey
casey reviewed Jan 6, 2023
View reviewed changes
src/subcommand/wallet.rs Outdated Show resolved Hide resolved
casey
casey reviewed Jan 6, 2023
View reviewed changes
tests/wallet.rs Outdated Show resolved Hide resolved
casey
casey reviewed Jan 6, 2023
View reviewed changes
src/options.rs Show resolved Hide resolved
casey
casey reviewed Jan 6, 2023
View reviewed changes
tests/wallet.rs Show resolved Hide resolved
casey
casey reviewed Jan 6, 2023
View reviewed changes
tests/wallet/create.rs Outdated Show resolved Hide resolved
rot13maxi
rot13maxi reviewed Jan 6, 2023
View reviewed changes
src/options.rs Outdated Show resolved Hide resolved
@raphjaph raphjaph requested a review from casey January 6, 2023 16:14
@casey casey mentioned this pull request Jan 7, 2023
Merged
casey
casey requested changes Jan 9, 2023
View reviewed changes
src/options.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
test-bitcoincore-rpc/src/server.rs Outdated Show resolved Hide resolved
tests/wallet.rs Outdated Show resolved Hide resolved
tests/wallet.rs Outdated Show resolved Hide resolved
tests/wallet/create.rs Outdated Show resolved Hide resolved
tests/wallet/create.rs Outdated Show resolved Hide resolved
tests/wallet/create.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/create.rs Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
@casey casey enabled auto-merge (squash) January 9, 2023 20:13
@casey casey merged commit 74cf38b into ordinals:master Jan 9, 2023
@raphjaph raphjaph deleted the wallet-with-fixed-descriptor branch May 1, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rot13maxi rot13maxi rot13maxi left review comments

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raphjaph @casey @rot13maxi