Use a two-element array instead of a vec for change addresses #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
force-pushed
the
change-address-array
branch
from
0e72925
to
a9cd19b
Compare
raphjaph
reviewed
Jan 19, 2023
| Dust { | ||
| output_value: Amount, | ||
| dust_value: Amount, | ||
| }, | ||
| ValueOverflow, | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe Target::Exact -> Target::TryExact ?
There was a problem hiding this comment.
Something to reflect that a non exact value can happen in some edge case like in this PR
raphjaph
reviewed
Jan 19, 2023
| @@ -19,7 +19,7 @@ jobs: | |||
| docs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
What's the reason for the downgrade?
raphjaph
reviewed
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also broke the fuzz target, so I integrated it with the rest of the workspace, so it should get checked for syntax errors on CI.