Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty preview #1287

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Empty preview #1287

merged 4 commits into from
Jan 19, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Jan 19, 2023

This fixes an issue where old inscriptions on signet with no body had previews containing error messages.

Changes the media function to return Media::Unknown if:

  • There is no body, since trying to preview an inscription with no body would return a 404.
  • The content type is unknown or otherwise invalid, since we don't know what it is.

/content will still return a 404 for an inscription with no body.

@casey casey linked an issue Jan 19, 2023 that may be closed by this pull request
@casey casey merged commit 7f44457 into master Jan 19, 2023
@casey casey deleted the empty-preview branch January 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unknown preview
1 participant