Serve PNG favicon to Safari and SVG favicon to other browsers #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was going to open an issue about no favicon on svgs but looks like this PR will resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One downside of specifying favicons in HTML is that it doesn't work for pages like HTML and SVG inscriptions, where we don't control the HTML. On those pages, the non-SVG favicon, which doesn't adjust to the user's theme, will be displayed.
To work around this, this PR uses user agent sniffing when /favicon.ico is requested to serve a PNG to Safari, and an SVG to all other browsers.