Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-reverse thumbnail row order #1321

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Un-reverse thumbnail row order #1321

merged 5 commits into from
Jan 23, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Jan 21, 2023

Fixes #1320. I did this so that left and right arrows would be consistent with thumbnail order, but @haribosan thought it was confusing, and I'm inclined to agree, so let's revert it.

@corebass
Copy link

I think that the arrows should now be inverted

@batcavekid
Copy link
Contributor

batcavekid commented Jan 21, 2023

Fixes https://github.com/casey/ord/issues/1320. I did this so that left and right arrows would be consistent with thumbnail order, but @haribosan thought it was confusing, and I'm inclined to agree, so let's revert it.

Good call, it felt weird.

@casey
Copy link
Collaborator Author

casey commented Jan 22, 2023

Made a separate issue for nav arrow order: https://github.com/casey/ord/issues/1327

@casey casey enabled auto-merge (squash) January 23, 2023 18:33
@casey casey merged commit 0ce7949 into master Jan 23, 2023
@casey casey deleted the un-reverse-thumbnail-direction branch January 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descending chronological order for inscriptions on ordinals.com
3 participants