Support STL inscriptions #1492
Merged
Support STL inscriptions #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
woah. That's gonna open some doors |
|
Nice, thanks for the review! |
|
I uploaded a .stl inscription and the content download outputs a .bin file, not a .stl. I am regarded and it took me all day to figure out to change the file name to .stl in windows explorer and it worked like a charm. (thanks Goodwin for the idea). Not sure if it would be possible to append the .stl filetype to the file name or something like that so it is more intuitive. https://ordinals.com/inscription/423b8403b8250bf226dec3d2ed342d971491ca8aaeaaab9d5d628d7dc744e2adi0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
model/stlwith extension.stltoMedia::TABLEwith typeMedia::Unknown. This will allow using.stlfiles withord wallet inscribe. However, they will not have any preview, since the media type is still unknown.A follow-up PR can add some kind of rendering/preview support.