Typo fix #1682
Merged
Typo fix #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psifour
suggested changes
Feb 12, 2023
|
I disagree. Your proposal puts the sentence into passive voice, which appears to contradict the way the other sentences are written (at a cursory glance). |
|
That is an acceptable opinion. ACK 55f838545349db965490a74fdeb59b14dd73f2f6 |
|
Discussion and an ack on a typo fix, making my life as a maintainer so easy❤️ Tried to merge, but phone UI is terrible, will merge later. In general, anything that is a pareto improvement can be insta-merged, and feedback/improvements can be deferred to a follow-up issue. A typo or grammar fix is almost always a Pareto improvement. Open PRs are my highest priority queue items, so I always want to merge, convert to draft, or close, to keep things moving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo "use maintain"