Add "ord wallet cardinals" command to list the cardinal outputs. #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonaut420
added a commit
to cryptonaut420/ord
that referenced
this pull request
Mar 12, 2023
|
This would really be helpful. I'm overwhelmed with the list of outputs and have difficulty discerning how many cardinal UTXOs and the balances that remain. @raphjaph Would you be the right person to tag for review? |
raphjaph
reviewed
Mar 27, 2023
src/subcommand/wallet.rs
Outdated
| @@ -48,6 +49,8 @@ pub(crate) enum Wallet { | |||
| Transactions(transactions::Transactions), | |||
| #[clap(about = "List wallet outputs")] | |||
| Outputs, | |||
| #[clap(about = "List wallet cardinals")] | |||
There was a problem hiding this comment.
Suggested change
| #[clap(about = "List wallet cardinals")] | |
| #[clap(about = "List unspent cardinal outputs in wallet")] |
src/subcommand/wallet.rs
Outdated
| @@ -48,6 +49,8 @@ pub(crate) enum Wallet { | |||
| Transactions(transactions::Transactions), | |||
| #[clap(about = "List wallet outputs")] | |||
There was a problem hiding this comment.
Suggested change
| #[clap(about = "List wallet outputs")] | |
| #[clap(about = "List all unspent outputs in wallet")] |
src/subcommand/wallet/cardinals.rs
Outdated
| .collect::<BTreeSet<OutPoint>>(); | ||
|
|
||
| let mut outputs = Vec::new(); | ||
| for (output, amount) in index.get_unspent_outputs(Wallet::load(&options)?)? { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no easy way to find a list of cardinal outputs. You have to list all the outputs and remove the inscriptions.
Hence:
ord wallet cardinals.