Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inscriptions with no sat are unbound #2107

Merged
merged 2 commits into from
May 24, 2023
Merged

Inscriptions with no sat are unbound #2107

merged 2 commits into from
May 24, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented May 23, 2023

No description provided.

@casey casey marked this pull request as draft May 23, 2023 22:16
@raphjaph
Copy link
Collaborator

Is this ready for review?

@casey
Copy link
Collaborator Author

casey commented May 23, 2023

@raphjaph Not yet, I tried it out, and i'm getting an error when I visit the /inscription page.

raphjaph

This comment was marked as resolved.

@raphjaph
Copy link
Collaborator

raphjaph commented May 23, 2023

@raphjaph Not yet, I tried it out, and i'm getting an error when I visit the /inscription page.

Probably because you're returning a Option<Sat> instead of a Sat and the boilerplate template expects it. But going to bed now. I'll look tomorrow

@casey casey marked this pull request as ready for review May 24, 2023 03:02
@casey
Copy link
Collaborator Author

casey commented May 24, 2023

@raphjaph Should be ready for review! When requesting /inscription, the server tries to look up the txout, i.e. the output value and script, for an inscription. Unbound inscriptions are on the 0…0:0 output, which doesn't exist, so this was failing. I changed the template to accept an Option<TxOut>, and return None in the case of unbound inscriptions.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaker of JPEG no more!

@casey casey merged commit 950740a into master May 24, 2023
6 checks passed
@casey casey deleted the unbound-sats branch May 24, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants