OP_PUSH instead of OP_1
#2135
Merged
OP_PUSH instead of OP_1
#2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veryordinally
approved these changes
May 31, 2023
There was a problem hiding this comment.
This looks good to me.
One point to consider: do we want to mention that earlier versions of the docs had OP_1 instead of OP_PUSH 1? Bit of a philosophical question, if we just want up to date docs, or also include historical info. I'd probably gravitate to not include changes explicitly - that's what we have Github for, after all.
|
This is a simplified overview anyway, so I don't think we need to include historical changes. |
hongshu7
pushed a commit
to hongshu7/ord
that referenced
this pull request
Jun 1, 2023
* commit '03f6867755c246cf4ea64b9d85134558ce06b9b5': `OP_PUSH` instead of `OP_1` in inscription docs (ordinals#2135) Fix typo in Sparrow Wallet docs (ordinals#2077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically should be a
OP_PUSHDATA1but this is simplified overview.