have ord respect locked coins #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
raphjaph
reviewed
Nov 1, 2023
raphjaph
requested changes
Nov 1, 2023
raphjaph
approved these changes
Nov 7, 2023
|
@rot13maxi, @dannydeezy I added some integration tests which unearthed another spot where we forgot to check locked outputs. Have a look if this looks good. @casey You can also have look at this. |
casey
approved these changes
Nov 8, 2023
|
awesome thanks for getting this across the line folks! |
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a refactor of #2563 on top of
masternow that everything is done throughBatch.