Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit cache size option #3158

Closed
wants to merge 3 commits into from

Conversation

bingryan
Copy link
Contributor

Description

When using a low memory cloud server, I found that reducing the commit cache size can increase index speed.

Use Case

ordxscan mainnet ord index.

@casey casey linked an issue Feb 22, 2024 that may be closed by this pull request
@casey
Copy link
Collaborator

casey commented Feb 24, 2024

Let's call this --commit-interval, also, it doesn't need to be an Option, because it has a default value.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@casey
Copy link
Collaborator

casey commented Feb 27, 2024

This needs to be rebased. Please allow this PR to be edited by maintainers, so we can rebase and merge.

@casey
Copy link
Collaborator

casey commented Feb 27, 2024

Closing for now, please ping this PR when it's editable by maintainers so we can merge it.

@casey casey closed this Feb 27, 2024
@bingryan
Copy link
Contributor Author

bingryan commented Feb 28, 2024

@casey have rebase to the latest, code review plz :)

@bingryan bingryan mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring commit cache size
3 participants