Index multi-parent inscriptions #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arik-so
force-pushed
the
multi-parent
branch
4 times, most recently
from
a37068e
to
5e3030d
Compare
arik-so
commented
Mar 7, 2024
src/inscriptions/inscription.rs
Outdated
| return None; | ||
| } | ||
| // the option detour is a bit awkward | ||
| Self::inscription_id_field(&Some(p.clone())) |
There was a problem hiding this comment.
Is the inscription_id_field method injective for Some return values? If it isn't and multiple Vec<u8> arguments can produce the same inscription id, the uniqueness check must be moved below the canonicalization.
arik-so
commented
Mar 7, 2024
| *parent = None; | ||
| } | ||
| } | ||
| parents.retain(|purported_parent| potential_parents.contains(purported_parent)); |
There was a problem hiding this comment.
Should a separate uniqueness check be introduced here?
arik-so
force-pushed
the
multi-parent
branch
3 times, most recently
from
e335afd
to
85a8ccd
Compare
arik-so
commented
Mar 8, 2024
Is this taken care of by the integration test that creates multiple distinct parents and then checks the array contents and order? |
Co-authored-by: raph <raphjaph@protonmail.com>
# Conflicts: # src/subcommand/server.rs
raphjaph
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables indexing and rendering multiple parents in a single inscription, addressing #2494.