Return effective content type in JSON API. #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
force-pushed
the
effective-content-type
branch
2 times, most recently
from
c77048c
to
b20c55f
Compare
|
One thing to note is that content-encoding could fall in a similar scenario. It might make more sense to return the delegate's mime type and content encoding, and perhaps create a separate field called direct/envelope/self (ask @casey for better nomenclature suggestions) which would have fields content_type and content_encoding that are the raw values in directly in the delegating inscription's envelope. |
arik-so
force-pushed
the
effective-content-type
branch
from
b20c55f
to
e08044a
Compare
arik-so
force-pushed
the
effective-content-type
branch
from
e08044a
to
70a12e8
Compare
vuviettai
pushed a commit
to codelight-co/runebeta_ord
that referenced
this pull request
Mar 28, 2024
harutyunaraci
pushed a commit
to brc721-core/ord
that referenced
this pull request
Mar 30, 2024
harutyunaraci
added a commit
to brc721-core/ord
that referenced
this pull request
Apr 2, 2024
This reverts commit 63ff8e9.
harutyunaraci
pushed a commit
to brc721-core/ord
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For inscriptions with delegates, the content type of the underlying delegate should be exposed. Fixes #3055.