Allow runestone to be deserialized from json #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for those of us doing integrations, allowing us to consume easier the protocol changes. |
|
Thanks for the PR! I removed the test, since we generally don't test automatically derived serialization implementations. |
|
Thanks for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow runestone to be deserialized from json.
This would be super-helpful intermediary step until we get a separate library for encoding/decoding payloads.
@casey @raphjaph , I know there are some versions of these that are already deserializable and used by the wallet(eg. wallet/inscribeetch.rs), but if wallet does not expose customization for some fields, they will not be included there. This is needed for protocol convertors, to actually have the exact same structures.