Document runes #3380
Merged
Document runes #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yo dog. i heard you like prs. so i pr'd your pr so you can review while you review |
raphjaph
approved these changes
Mar 27, 2024
vuviettai
pushed a commit
to codelight-co/runebeta_ord
that referenced
this pull request
Mar 28, 2024
twhit223
reviewed
Mar 29, 2024
|
|
||
| A rune may not be minted in or after the block whose height is equal to the end | ||
| offset plus the height of the block in which the rune was etched. | ||
|
|
There was a problem hiding this comment.
What is the behavior if neither a premine nor terms are specified? It seems the default for each of those is 0/do nothing. Does that etch a valid rune with 0 max supply (effectively "burning" the name), or does it create a cenotaph (and burn all runes that are also on that tx)?
There was a problem hiding this comment.
If neither premine nor terms are supplied, the supply is zero, but the runestone is not a cenotaph.
harutyunaraci
pushed a commit
to brc721-core/ord
that referenced
this pull request
Mar 30, 2024
harutyunaraci
added a commit
to brc721-core/ord
that referenced
this pull request
Apr 2, 2024
This reverts commit b8dfbf3.
harutyunaraci
pushed a commit
to brc721-core/ord
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.