Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass benchmark dir name in justfile recipe #498

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

casey
Copy link
Collaborator

@casey casey commented Sep 8, 2022

The way this was being done before relied on ./bin/benchmark {{dir}} not resulting in an argument being passed when dir is "", which is a somewhat unintuitive side effect of the way just evaluates recipe lines. Changing it so it always passes in the directory argument.

@casey casey enabled auto-merge (squash) September 8, 2022 22:36
@casey casey merged commit d9ff342 into master Sep 8, 2022
@casey casey deleted the require-dir-argument branch September 8, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant