Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more links and labels to clocks #552

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Add more links and labels to clocks #552

merged 6 commits into from
Sep 26, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Sep 23, 2022

Fixes #489 and #387.

@casey casey requested a review from raphjaph September 23, 2022 22:11
raphjaph
raphjaph reviewed Sep 26, 2022
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
raphjaph
raphjaph reviewed Sep 26, 2022
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
raphjaph
raphjaph requested changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! Maybe just change the url in the test to clarify that it is a path

casey and others added 3 commits September 26, 2022 10:38
@casey @raphjaph
Update src/subcommand/server.rs
5907fe4 
Co-authored-by: raphjaph <raphjaph@protonmail.com>
@casey @raphjaph
Update src/subcommand/server.rs
dbc7da4 
Co-authored-by: raphjaph <raphjaph@protonmail.com>
@casey
Merge branch 'master' into clock-improvements
13cd159
@casey casey requested a review from raphjaph September 26, 2022 17:39
@casey casey enabled auto-merge (squash) September 26, 2022 17:53
@casey casey requested review from raphjaph and removed request for raphjaph September 26, 2022 17:53
@casey casey merged commit e310c82 into master Sep 26, 2022
@casey casey deleted the clock-improvements branch September 26, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clock marks should link to ordinal mined in that block
2 participants
@casey @raphjaph