Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows tests on CI #846

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Enable Windows tests on CI #846

merged 2 commits into from
Dec 5, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 25, 2022

Some tests is better than no tests! Run tests on Windows CI, but disable failing tests. These seem to be flaky, so we shouldn't merge this for now. Opened an issue w/redb: cberner/redb#449

@casey casey changed the title Enable tests on windows Enable passing Windows tests on CI Nov 25, 2022
@casey casey marked this pull request as ready for review November 25, 2022 06:14
@casey casey requested a review from raphjaph November 25, 2022 06:25
@casey casey marked this pull request as draft November 25, 2022 06:44
@casey casey marked this pull request as ready for review December 3, 2022 00:10
@casey
Copy link
Collaborator Author

casey commented Dec 3, 2022

@raphjaph This is working, have a look! The HOME environment variable isn't used to determine the location of dirs::data_dir on Windows, so I changed the tests to just pass --data-dir instead.

@casey casey linked an issue Dec 3, 2022 that may be closed by this pull request
@casey casey changed the title Enable passing Windows tests on CI Enable Windows tests on CI Dec 3, 2022
@casey casey merged commit 87832c6 into master Dec 5, 2022
@casey casey deleted the test-on-windows branch December 5, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tests pass on windows
2 participants