Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS and malloc capturing should only be enabled when requested #34

Closed
hassila opened this issue Oct 10, 2022 · 0 comments · Fixed by #36
Closed

OS and malloc capturing should only be enabled when requested #34

hassila opened this issue Oct 10, 2022 · 0 comments · Fixed by #36

Comments

@hassila
Copy link
Contributor

hassila commented Oct 10, 2022 •
edited

Currently we capture OS and malloc stats for any benchmark run, we should avoid the overhead of doing that if we have a benchmark run that doesn't request those stats. Especially important for malloc stats that turned out to have the most significant overhead.
@hassila hassila mentioned this issue Oct 11, 2022
Merged
hassila added a commit that referenced this issue Oct 11, 2022
@hassila
fix: Only query and check malloc and operating system stats when need…
4724d72 
…ed (#36)

Significantly decreases the overhead when only measuring e.g.
`.wallClock`/`.throughput`.

Fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Only query and check malloc and operating system stats when needed ordo-one/package-benchmark
1 participant
@hassila